Add marker rabbit_queue_type behaviour #2062
Conversation
dumbbell
left a comment
dumbbell
left a comment
There was a problem hiding this comment.
My main concern is that the amqqueue module and its API is already public (starting with 3.7.17). Therefore we can't get rid of a few aspects of it.
RabbitMQ 3.7.x does not use the amqqueue module: it was backported for plugin developers only (they can maintain and publish a single copy of their plugin and it will be compatible with 3.7.x and 3.8.x). So it should be easy to keep support for those few bits being removed. I need to think about this.
dumbbell
left a comment
dumbbell
left a comment
There was a problem hiding this comment.
In amqqueue.erl, before line 346, you need to convert the passed Type if it is classic. Otherwise, that's what is stored in the record.
dumbbell
left a comment
dumbbell
left a comment
There was a problem hiding this comment.
Could you please squash all commits into one?
And use the implementing module as the value of the amqqueue record `type` field. This will allow for easy dispatch to the queue type implementation. Make amqqueue compatible with the classic queue tag
kjnilsson
force-pushed
the
queue_type_scaffolding
branch
from
3341875 to
3444925
Compare
And use the implementing module as the value of the amqqueue record
typefield. This will allow for easy dispatch to the queue typeimplementation.
Also change the quorum_nodes field to a more generic queue type state field that holds an extensible queue type specific map.
This is a first step towards a full queue type behaviour as worked on in #2052