Do not "pre convert" running_nodes to strings
#14381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Aug 13, 2025
Collaborator
the-mikedavis
left a comment
the-mikedavis
left a comment
There was a problem hiding this comment.
Works on my machine too 👍
Collaborator
|
Thank you for the quick turnaround, @lukebakken @the-mikedavis! |
michaelklishin
added a commit
that referenced
this pull request
Aug 13, 2025
Do not "pre convert" `running_nodes` to strings (backport #14381)
Member
|
Thank you @lukebakken and @the-mikedavis ! |
lukebakken
added a commit
to lukebakken/rmq-rabbitmq-server
that referenced
this pull request
Sep 5, 2025
A list of binaries was incorrectly converted by `unicode:characters_to_binary` into one big binary. Add a function head to match this case. Also, add tests for the values that were not correctly formatted prior to rabbitmq#14101 and rabbitmq#14381
lukebakken
added a commit
that referenced
this pull request
Sep 5, 2025
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2025
A list of binaries was incorrectly converted by `unicode:characters_to_binary` into one big binary. Add a function head to match this case. Also, add tests for the values that were not correctly formatted prior to #14101 and #14381 (cherry picked from commit 3280bed) (cherry picked from commit fe0697d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #14118
Without this PR:
With this PR: