Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Aug 11, 2025

This version forces prefixed binaries
(such as encrypted:TkQbjiVWtUJw3Ed/hkJ5JIsFIyhruKII6uKPXogfvDyMXGH1qQK3hVqshFolLN0S) to have alphanumeric prefixes ([a-zA-Z0-9_]+).

This allows us to tell a generated password value
with a colon from an tagged binary, for example:

# this is a not an encrypted value, or, in Cuttlefish speak,
# not a tagged one, so parse it has a "regular" password (binary)
default_password = 'abd:def07df783'
# this is an encrypted/tagged value,
# so parse it as a tagged tuple,
# {encrypted, <<"GhC4J5lh2DUkbdyKO0aMI8aYJ54mwe4eEWzou4yRFAHMF82IbD6cRiYAiBa8UIzR">>)
default_pass = encrypted:GhC4J5lh2DUkbdyKO0aMI8aYJ54mwe4eEWzou4yRFAHMF82IbD6cRiYAiBa8UIzR

If a value of, say, default_pass or ssl_options.password cannot be parsed as a tagged value, it will be parsed as a regular binary, because rabbit.schema
specifies multiple types as supported.

References #14233.


This is an automatic backport of pull request #14364 done by [Mergify](https://mergify.com).

This version forces prefixed binaries
(such as encrypted:TkQbjiVWtUJw3Ed/hkJ5JIsFIyhruKII6uKPXogfvDyMXGH1qQK3hVqshFolLN0S)
to have alphanumeric prefixes ([a-zA-Z0-9_]+).

This allows us to tell a generated password value
with a colon from an tagged binary.

If a value of, say, default_pass or ssl_options.password
cannot be parsed as a tagged value, it will be
parsed as a regular binary, because rabbit.schema
specifies multiple types as supported.

References #14233.

(cherry picked from commit 7413511)
@mergify mergify bot added the make label Aug 11, 2025
@michaelklishin michaelklishin added this to the 4.1.4 milestone Aug 11, 2025
@michaelklishin michaelklishin merged commit 5ed8ac5 into v4.1.x Aug 11, 2025
545 of 547 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.1.x/pr-14364 branch August 11, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants