Skip to content

Conversation

@Zerpet
Copy link
Member

@Zerpet Zerpet commented Jun 12, 2025

Proposed Changes

The leading v in PROJECT_VERSION is breaking some tests that
parse the version returned by the broker.

Prior to #13890, the "nightly" OCI was built on every commit, and other workflows/tests
relied on those images. The OCI (Make) workflow sets the PROJECT_VERSION to a hardcoded
value + a commit SHA. This PR mimics that behaviour for RabbitMQ project version.

There is one improvement: the semver part of the project version now follows the closest
(i.e. latest) tag on their respective branch. For example, OCIs from branch v4.0.x will follow
the tags for 4.0 releases e.g. 4.0.9, and use the tag as the semver component in the project version,
resulting in RabbitMQ reporting its version as {tag}+{git-commit-sha}. main is hard-coded to
4.2.0, instead of following a tag.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

The leading `v` in the PROJECT_VERSION is breaking some tests, that
expect to parse the version returned by the broker, without a leading
`v`.
@Zerpet Zerpet requested a review from acogoluegnes June 12, 2025 09:44
@acogoluegnes acogoluegnes merged commit e4db147 into main Jun 12, 2025
1 of 282 checks passed
@acogoluegnes acogoluegnes deleted the ci/tweak-oci-tags branch June 12, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants