Skip to content

Fix issue introduced by #13512 #14033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Fix issue introduced by #13512 #14033

merged 2 commits into from
Jun 6, 2025

Conversation

lukebakken
Copy link
Collaborator

Moves Sammy.Title plugin into its own file.

Fixes #13973

@lukebakken lukebakken self-assigned this Jun 4, 2025
@lukebakken lukebakken requested a review from ikavgo June 4, 2025 21:21
@lukebakken
Copy link
Collaborator Author

This appears to fix the issue after upgrade, but then it seems like light/dark mode isn't immediately applied until a refresh happens 🤔

@ikavgo
Copy link
Contributor

ikavgo commented Jun 4, 2025

I like it. In my Web days we did concatenation + compaction + hash in the name - no chances to suffer from cache unless html page itself cached.

@michaelklishin
Copy link
Collaborator

@lukebakken until an automatic (every 5s by default) refresh happens? Does it mean the user has to wait for 5s once after upgrading and then the selected team applies?

@lukebakken
Copy link
Collaborator Author

until an automatic (every 5s by default) refresh happens? Does it mean the user has to wait for 5s once after upgrading and then the selected team applies?

I just re-tested an upgrade from 3.13.x -> 4.0.x -> 4.1.x (broken UI) -> main (with my patch) and a refresh / force-refresh is not necessary. That must have been due to me skipping intermediate versions.

Moves Sammy.Title plugin into its own file
@lukebakken lukebakken force-pushed the rabbitmq-server-13973-2 branch from b369a92 to 1014183 Compare June 4, 2025 22:04
@lukebakken lukebakken marked this pull request as ready for review June 4, 2025 22:04
@michaelklishin michaelklishin merged commit 724338e into main Jun 6, 2025
557 of 558 checks passed
@michaelklishin michaelklishin deleted the rabbitmq-server-13973-2 branch June 6, 2025 06:25
michaelklishin added a commit that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading from 3.13.x to 4.x breaks management UI
3 participants