Allow non-deterministic builds #13899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building from source using this command:
```
make RMQ_ERLC_OPTS= FULL=1
```
... then starting RabbitMQ via `make run-broker`, allows re-compilation
from the erl shell:
```
1> c(rabbit).
Recompiling /home/lbakken/development/rabbitmq/rabbitmq-server/deps/rabbit/src/rabbit.erl
{ok,rabbit}
```
When `+deterministic` is passed to `erlc`, the `compile` data in each
modules' information is missing the source path for the module.
Follow-up to #3442
Collaborator
Author
|
Of course, #3442 could just be reverted. |
michaelklishin
approved these changes
May 17, 2025
Collaborator
michaelklishin
left a comment
michaelklishin
left a comment
There was a problem hiding this comment.
No objections to simply merging this PR instead of reverting. We keep more context in git history that way IMO.
Collaborator
|
The Selenium suite fails due to limited secret access, please disregard. |
michaelklishin
added a commit
that referenced
this pull request
May 17, 2025
Allow non-deterministic builds (backport #13899)
lukebakken
added a commit
to lukebakken/rmq-rabbitmq-server
that referenced
this pull request
Sep 18, 2025
Follow-up to: * rabbitmq#3442 * 93db480 * rabbitmq#13899 * rabbitmq#14326 Simply changing `+=` to `?=` doesn't work as there are other important statements added to `RMQ_ERLC_OPTS` that can't be left out when `make RMQ_ERLC_OPTS=''` is run. This only became apparent when a completely cleaned-out checkout of `rabbitmq/rabbitmq-server` was attempted to be built with that command. This adds `RMQ_NON_DETERMINISTIC_BUILD` which will be used like this: ``` make RMQ_NON_DETERMINISTIC_BUILD=true ``` ...and `+deterministic` won't be passed to `erlc` or other commands.
lukebakken
added a commit
to lukebakken/rmq-rabbitmq-server
that referenced
this pull request
Sep 19, 2025
Follow-up to: * rabbitmq#3442 * 93db480 * rabbitmq#13899 * rabbitmq#14326 Simply changing `+=` to `?=` doesn't work as there are other important statements added to `RMQ_ERLC_OPTS` that can't be left out when `make RMQ_ERLC_OPTS=''` is run. This only became apparent when a completely cleaned-out checkout of `rabbitmq/rabbitmq-server` was attempted to be built with that command. This adds `RMQ_NON_DETERMINISTIC_BUILD` which will be used like this: ``` make RMQ_NON_DETERMINISTIC_BUILD=true ``` ...and `+deterministic` won't be passed to `erlc` or other commands.
lukebakken
added a commit
to lukebakken/rmq-rabbitmq-server
that referenced
this pull request
Sep 19, 2025
Follow-up to: * rabbitmq#3442 * 93db480 * rabbitmq#13899 * rabbitmq#14326 Simply changing `+=` to `?=` doesn't work as there are other important statements added to `RMQ_ERLC_OPTS` that can't be left out when `make RMQ_ERLC_OPTS=''` is run. This only became apparent when a completely cleaned-out checkout of `rabbitmq/rabbitmq-server` was attempted to be built with that command. This adds `RMQ_NON_DETERMINISTIC_BUILD` which will be used like this: ``` make RMQ_NON_DETERMINISTIC_BUILD=true ``` ...and `+deterministic` won't be passed to `erlc` or other commands.
lukebakken
added a commit
to lukebakken/rmq-rabbitmq-server
that referenced
this pull request
Sep 22, 2025
Follow-up to: * rabbitmq#3442 * 93db480 * rabbitmq#13899 * rabbitmq#14326 Simply changing `+=` to `?=` doesn't work as there are other important statements added to `RMQ_ERLC_OPTS` that can't be left out when `make RMQ_ERLC_OPTS=''` is run. This only became apparent when a completely cleaned-out checkout of `rabbitmq/rabbitmq-server` was attempted to be built with that command. This adds `RMQ_NON_DETERMINISTIC_BUILD` which will be used like this: ``` make RMQ_NON_DETERMINISTIC_BUILD=true ``` ...and `+deterministic` won't be passed to `erlc` or other commands.
lukebakken
added a commit
to lukebakken/rmq-rabbitmq-server
that referenced
this pull request
Sep 22, 2025
Follow-up to: * rabbitmq#3442 * 93db480 * rabbitmq#13899 * rabbitmq#14326 Simply changing `+=` to `?=` doesn't work as there are other important statements added to `RMQ_ERLC_OPTS` that can't be left out when `make RMQ_ERLC_OPTS=''` is run. This only became apparent when a completely cleaned-out checkout of `rabbitmq/rabbitmq-server` was attempted to be built with that command. This adds `RMQ_NON_DETERMINISTIC_BUILD` which will be used like this: ``` make RMQ_NON_DETERMINISTIC_BUILD=true ``` ...and `+deterministic` won't be passed to `erlc` or other commands.
lukebakken
added a commit
to lukebakken/rmq-rabbitmq-server
that referenced
this pull request
Sep 24, 2025
Follow-up to: * rabbitmq#3442 * 93db480 * rabbitmq#13899 * rabbitmq#14326 Simply changing `+=` to `?=` doesn't work as there are other important statements added to `RMQ_ERLC_OPTS` that can't be left out when `make RMQ_ERLC_OPTS=''` is run. This only became apparent when a completely cleaned-out checkout of `rabbitmq/rabbitmq-server` was attempted to be built with that command. This adds `RMQ_NON_DETERMINISTIC_BUILD` which will be used like this: ``` make RMQ_NON_DETERMINISTIC_BUILD=true ``` ...and `+deterministic` won't be passed to `erlc` or other commands.
lukebakken
added a commit
to lukebakken/rmq-rabbitmq-server
that referenced
this pull request
Sep 24, 2025
Follow-up to: * rabbitmq#3442 * 93db480 * rabbitmq#13899 * rabbitmq#14326 Simply changing `+=` to `?=` doesn't work as there are other important statements added to `RMQ_ERLC_OPTS` that can't be left out when `make RMQ_ERLC_OPTS=''` is run. This only became apparent when a completely cleaned-out checkout of `rabbitmq/rabbitmq-server` was attempted to be built with that command. This adds `RMQ_NON_DETERMINISTIC_BUILD` which will be used like this: ``` make RMQ_NON_DETERMINISTIC_BUILD=true ``` ...and `+deterministic` won't be passed to `erlc` or other commands.
lukebakken
added a commit
to lukebakken/rmq-rabbitmq-server
that referenced
this pull request
Sep 25, 2025
Follow-up to: * rabbitmq#3442 * 93db480 * rabbitmq#13899 * rabbitmq#14326 Simply changing `+=` to `?=` doesn't work as there are other important statements added to `RMQ_ERLC_OPTS` that can't be left out when `make RMQ_ERLC_OPTS=''` is run. This only became apparent when a completely cleaned-out checkout of `rabbitmq/rabbitmq-server` was attempted to be built with that command. This adds `NON_DETERMINISTIC` which will be used like this: ``` make NON_DETERMINISTIC=true ``` ...and `+deterministic` won't be passed to `erlc` or other commands.
lukebakken
added a commit
that referenced
this pull request
Sep 25, 2025
Follow-up to: * #3442 * 93db480 * #13899 * #14326 Simply changing `+=` to `?=` doesn't work as there are other important statements added to `RMQ_ERLC_OPTS` that can't be left out when `make RMQ_ERLC_OPTS=''` is run. This only became apparent when a completely cleaned-out checkout of `rabbitmq/rabbitmq-server` was attempted to be built with that command. This adds `NON_DETERMINISTIC` which will be used like this: ``` make NON_DETERMINISTIC=true ``` ...and `+deterministic` won't be passed to `erlc` or other commands.
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
Follow-up to: * #3442 * 93db480 * #13899 * #14326 Simply changing `+=` to `?=` doesn't work as there are other important statements added to `RMQ_ERLC_OPTS` that can't be left out when `make RMQ_ERLC_OPTS=''` is run. This only became apparent when a completely cleaned-out checkout of `rabbitmq/rabbitmq-server` was attempted to be built with that command. This adds `NON_DETERMINISTIC` which will be used like this: ``` make NON_DETERMINISTIC=true ``` ...and `+deterministic` won't be passed to `erlc` or other commands. (cherry picked from commit 2eb8ce5)
michaelklishin
pushed a commit
that referenced
this pull request
Sep 26, 2025
Follow-up to: * #3442 * 93db480 * #13899 * #14326 Simply changing `+=` to `?=` doesn't work as there are other important statements added to `RMQ_ERLC_OPTS` that can't be left out when `make RMQ_ERLC_OPTS=''` is run. This only became apparent when a completely cleaned-out checkout of `rabbitmq/rabbitmq-server` was attempted to be built with that command. This adds `NON_DETERMINISTIC` which will be used like this: ``` make NON_DETERMINISTIC=true ``` ...and `+deterministic` won't be passed to `erlc` or other commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building from source using this command:
... then starting RabbitMQ via
make run-broker, allows re-compilation from the erl shell:When
+deterministicis passed toerlc, thecompiledata in each modules' information is missing the source path for the module.Follow-up to #3442