Shovel: keep track of forwarded message count (a new metric) #13620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delayed queuese can automatically create associated Shovels to transfer Ready messages to the desired destination. This adds forwarded messages counter which will be used in Management UI for better Shovel internals visibility. (cherry picked from commit a8800b6cd75d8dc42a91f88655058f2ffa3b6ea6)
(cherry picked from commit 68872f81074d378f76ffa44e7111e7979cdd8fd0)
(cherry picked from commit af22cf427a7054d93b3dd64fda01a86649fdd7c5)
michaelklishin
changed the title
Collaborator
Author
|
@ikavgo @dcorbacho the test failures do not seem to be flakes. Please take a look at what might be missing in this upstream PR. |
Contributor
|
whole shovel_prometheus got lost somewhere, re-added. |
Contributor
|
It's failing in mixed cluster tests. So in the old versions we have different Status tuple, and test expects new one in |
Collaborator
Author
|
I'm looking into what in the |
michaelklishin
added a commit
that referenced
this pull request
Mar 26, 2025
Shovel: keep track of forwarded message count (a new metric) (backport #13620)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work was originally done by @ikavgo in Tanzu RabbitMQ with @dcorbacho's reviews.