-
Notifications
You must be signed in to change notification settings - Fork 4k
Remove Bazel files #13514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Bazel files #13514
Conversation
|
This is what's left of Bazel in our code base after this change. git grep bazel
# deps/rabbit/test/amqp_client_SUITE.erl: %% rabbit/Makefile and rabbit/BUILD.bazel declare a test dependency on the rabbitmq_amqp1_0 plugin.
# deps/rabbit/test/feature_flags_SUITE.erl: %% bazel
# deps/rabbitmq_cli/mix.exs: is_bazel = System.get_env("IS_BAZEL") != nil
# deps/rabbitmq_cli/mix.exs: compile: if(is_bazel, do: fake_cmd, else: make_cmd)
# deps/rabbitmq_cli/mix.exs: compile: if(is_bazel, do: fake_cmd, else: make_cmd),
# deps/rabbitmq_cli/mix.exs: compile: if(is_bazel, do: fake_cmd, else: make_cmd),
# deps/rabbitmq_cli/mix.exs: compile: if(is_bazel, do: fake_cmd, else: make_cmd),
# deps/rabbitmq_ct_helpers/src/rabbit_ct_broker_helpers.erl: %% bazel coverage
# deps/rabbitmq_ct_helpers/src/rabbit_ct_helpers.erl: % Some tests under bazel use this value, others do not.
# deps/rabbitmq_ct_helpers/src/rabbit_ct_helpers.erl: %% skip if bazel
# release-notes/3.9.0.md: [Bazel support for Erlang](https://github.com/rabbitmq/bazel-erlang) is a new project open sourced by the RabbitMQ Core team as a result.
# selenium/README.md:>> Equivalent bazel command: `bazelisk run packaging/docker-image:rabbitmq`
# selenium/README.md:Or if you prefer to use bazel run instead:
# selenium/README.md:bazelisk run packaging/docker-image:rabbitmq
# selenium/README.md:or like this if you built the docker image using bazel:
# selenium/README.md:RABBITMQ_DOCKER_IMAGE=bazel/packaging/docker-image:rabbitmq suites/authnz-mgt/oauth-with-uaa-with-mgt-prefix.sh
git grep bzl
# Makefile: --exclude '*.bzl' \I'm not sure how to make the changes to |
|
Don’t worry about mix(1), we will stop using it shortly, thanks to #12922. And mid/long-term, we will get rid of Elixir entirely. For rabbitmq_ct_helpers, that’s ok too, it works with GNU make. We can clean up the code later when we have an opportunity. |
At least this one can be safely removed (the line). |
|
The |
053c952 to
43f9991
Compare
|
I removed the lines suggested by @lhoguin ✂️ The first commit run without any major incidents. I saw some errors in mixed clusters, but none of them looked related to Bazel removal. Example run: https://github.com/rabbitmq/rabbitmq-server/actions/runs/13836164154 |
Remove Bazel files (backport #13514)
Proposed Changes
Remove Bazel files. We are no longer using Bazel to build or to test. Bazel was a great tool for our team,
it provided a much needed capability of caching and build optimisation. However, in recent times, we decided
to focus on Make and erlang.mk, thus this PR has taken place.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
Closes #13494