Fix direct reply to crash when tracing is enabled (backport #11665) #11666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes https://github.com/rabbitmq/rabbitmq-server/discussions/11662 Prior to this commit the following crash occurred when an RPC reply message entered RabbitMQ and tracing was enabled: ``` ** Reason for termination == ** {function_clause, [{rabbit_trace,'-tap_in/6-fun-0-', [{virtual_reply_queue, <<"amq.rabbitmq.reply-to.g1h2AA5yZXBseUAyNzc5NjQyMAAAC1oAAAAAZo4bIw==.+Uvn1EmAp0ZA+oQx2yoQFA==">>}], [{file,"rabbit_trace.erl"},{line,62}]}, {lists,map,2,[{file,"lists.erl"},{line,1559}]}, {rabbit_trace,tap_in,6,[{file,"rabbit_trace.erl"},{line,62}]}, {rabbit_channel,handle_method,3, [{file,"rabbit_channel.erl"},{line,1284}]}, {rabbit_channel,handle_cast,2, [{file,"rabbit_channel.erl"},{line,659}]}, {gen_server2,handle_msg,2,[{file,"gen_server2.erl"},{line,1056}]}, {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,241}]}]} ``` (Note that no trace message is emitted for messages that are delivered to direct reply to requesting clients (neither in 3.12, nor in 3.13, nor after this commit). This behaviour can be added in future when a direct reply virtual queue becomes its own queue type.) (cherry picked from commit 5deff45)
…erence (cherry picked from commit 348ca6f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #11662
Prior to this commit the following crash occurred when an RPC reply message entered RabbitMQ and tracing was enabled:
(Note that no trace message is emitted for messages that are delivered to direct reply to requesting clients (neither in 3.12, nor in 3.13, nor after this commit). This behaviour can be added in future when a direct reply virtual queue becomes its own queue type.)
This is an automatic backport of pull request #11665 done by Mergify.