Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amqp10_client: allow configuring global TLS options #11369

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

gomoripeti
Copy link
Contributor

Proposed Changes

Since OTP 26 the verify_peer TLS option is enabled by default, which requires to specify cacerts as well. This change helps with not having to specify TLS options like cacertfile at every connection. This is especially helpful for shovels using AMQP 1.0, where the TLS options would otherwise need to be specified as URI parameters.

Similar env configuration already exists for amqp_client. (The option name ssl_options is chosen over tls_options or tls_opts because the former is widely used across RabbitMQ applications)

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

Since OTP 26 the verify_peer TLS option is enabled by default, which
requires to specify cacerts as well. This change helps with not having
to specify TLS options like cacertfile at every connection. This is
especially helpful for shovels using AMQP 1.0, where the TLS options
would otherwise need to be specified as URI parameters. Similar env
configuration already exists for amqp_client.
@michaelklishin michaelklishin merged commit 55b38bd into rabbitmq:main Jun 4, 2024
9 checks passed
michaelklishin added a commit that referenced this pull request Jun 4, 2024
michaelklishin added a commit that referenced this pull request Jun 4, 2024
amqp10_client: allow configuring global TLS options (backport #11369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants