Notify of permission and parameter deletions when deleting a vhost #11077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
force-pushed
the
md/vhost-notify-deletions
branch
3 times, most recently
from
d36e292 to
2143108
Compare
These changes to the defaults can affect other test cases. In particular it will affect the time to live and deletion events in the vhost deletion idempotency case.
the-mikedavis
force-pushed
the
md/vhost-notify-deletions
branch
from
2143108 to
d4584a3
Compare
Previously `rabbit_vhost:delete/2` threw this error within `rabbit_policy:list/2` when the vhost didn't exist. We can return the value instead so that `rabbitmqctl delete_vhost` behaves the same between these changes and the branch fork point. The `rabbit_vhost_sup_sup:delete_on_all_nodes/1` cleanup is idempotent so we can run all teardown steps for the vhost and return this error instead. This might be useful if deletion fails for some resources under the vhost, for example a queue. If the vhost record is gone it might still be useful to try to clean up the vhost's resources.
the-mikedavis
force-pushed
the
md/vhost-notify-deletions
branch
from
d4584a3 to
39c6093
Compare
michaelklishin
approved these changes
Apr 26, 2024
michaelklishin
added a commit
that referenced
this pull request
Apr 27, 2024
Notify of permission and parameter deletions when deleting a vhost (backport #11077)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6430 caused some subtle regressions in the events sent through
rabbit_event:notify/2when deleting a vhost. These notifications were thunks that mnesia transactions returned but that was refactored in #6430 to be explicit calls for most callers. Runtime parameters and permissions also need some changes so that they send notifications when deleted.I've also added the vhost name to the
rabbit_vhost_limitnotifications for testing purposes but it should be useful anyways.