Have minimum queue TTL take effect for quorum queues #10949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is also consistent with how the regular policy vs. operator policy tie break works for limits such as TTL and queue length limits: the lower (and safer w.r.t. resource use) wins. |
michaelklishin
approved these changes
Apr 9, 2024
michaelklishin
force-pushed
the
qq-expires
branch
from
cedc2d9
to
40b430b
Compare
For classic queues, if both policy and queue argument are set for queue TTL, the minimum takes effect. Prior to this commit, for quorum queues if both policy and queue argument are set for queue TTL, the policy always overrides the queue argument. This commit brings the quorum queue queue TTL resolution to classic queue's behaviour. This allows developers to provide a custom lower queue TTL while the operator policy acts an upper bound safe-guard.
|
We can ship this PR only in 4.0 because it could otherwise come as a surprise to existing client applications which rely on today's 3.13 behaviour and therefore deleting quorum queues earlier than expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For classic queues, if both policy and queue argument are set for queue TTL, the minimum takes effect.
Prior to this commit, for quorum queues if both policy and queue argument are set for queue TTL, the policy always overrides the queue argument.
This commit brings the quorum queue queue TTL resolution to classic queue's behaviour. This allows developers to provide a custom lower queue TTL while the operator policy acts an upper bound safe-guard.