-
Notifications
You must be signed in to change notification settings - Fork 615
Refactor: extracted RabbitMQ node management functions from IntegrationFixture #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: extracted RabbitMQ node management functions from IntegrationFixture #884
Conversation
Simplifying IntegrationFixture. Make reuse of code for controlling RabbitMQ server simpler.
|
Thank you for considering a contribution. I'm not sure how this makes much difference or make anything simpler (easier, possibly, but not sure what). It's already possible to run tests with a RabbitMQ node running in a container and override the expected Also, we never spell RabbitMQ as "RabbitMq" and "server controller" at first made me think this was a contribution to the Kubernetes operator repository. IIRC Java client uses |
|
Thanks for prompt reply! In context of the RabbitMQClient itself the change makes the code only marginally cleaner. Our reason to refactor is that we are making heavy use of RabbitMQ in our solution, and need to test the robustness of our services in regards to RabbitMQ availability. The proposed extraction of RabbitMQCtl from IntegrationFixture makes it easy for us to reuse tested code from the rabbitmq-dotnet-client repository. If we can give this back to the community, so much the better. RabbitMQCtl is a better name, yes. Renamed. |
michaelklishin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification. I see no reason not to extract this class then. @lukebakken?
|
Thanks for explaining @pergh. I figured that was the reason. I'll review this today. |
Proposed Changes
Reuse of code for controlling RabbitMQ server is made simpler for external projects.
IntegrationFixture is now simpler and does no longer contain low level RabbitMQ server controlling methods.
Types of Changes
Checklist
CONTRIBUTING.mddocument