Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jun 15, 2020

Proposed Changes

Report a Uri scheme of "amqps" in AmqpTcpEndpoint.ToString() iff Ssl.Enabled == true.

Fixes Issue #861 and thereby makes the output of AmqpTcpEndpoint.ToString() consistent with e.g. ConnectionFactory.SetUri(...).

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • [ x] I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • [ x] All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

@pivotal-issuemaster This is an Obvious Fix

@michaelklishin michaelklishin merged commit c93144a into rabbitmq:master Jun 15, 2020
michaelklishin added a commit that referenced this pull request Jun 15, 2020
Report a Uri scheme of "amqps" in AmqpTcpEndpoint.ToString() iff SslOption is enabled

(cherry picked from commit c93144a)
@lukebakken lukebakken self-assigned this Jun 15, 2020
@lukebakken lukebakken added this to the 6.1.1 milestone Jun 15, 2020
@michaelklishin
Copy link
Contributor

Backported to 6.x.

@lukebakken lukebakken modified the milestones: 6.1.1, 6.2.0 Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants