-
Notifications
You must be signed in to change notification settings - Fork 615
Allow setting heartbeat timeout to TimeSpan.Zero
#1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #1756 * Add test that demonstrates the issue.
TimeSpan.Zero
|
If you could test this PR in your environment, we would appreciate it. Thanks. |
justcuriousstill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested changes in my environment.
Tests.
Client Heartbeat Timeout = 0. Server Heartbeat Timeout = 60.
Expected Result = ArgumentOutOfRangeException not raised and a new connection with Heartbeat = 60 secs. PASS.
Client Heartbeat Timeout = 30. Server Heartbeat Timeout = 60.
Expected Result = ArgumentOutOfRangeException not raised and a new connection with Heartbeat = 30 secs. PASS.
Client Heartbeat Timeout = 90. Server Heartbeat Timeout = 60.
Expected Result = ArgumentOutOfRangeException not raised and a new connection with Heartbeat = 60 secs. PASS.
The Heartbeat Timeout behaviour now works as it did in v6 so thanks very much for resolving it so quickly.
|
@justcuriousstill thank you for testing! |
Fixes #1756