-
Notifications
You must be signed in to change notification settings - Fork 615
Fix exception when refreshing oauth2 token #1690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception when refreshing oauth2 token #1690
Conversation
|
Thank you for this PR @BreakingBread0. Would you mind sharing which version of this library you found this issue in? |
The versions I currently use (and in which I found the bug) are:
|
ec0f472 to
1dab877
Compare
lukebakken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @BreakingBread0
Proposed Changes
This fixes a small bug that happens when refreshing the OAuth2 access token from the OAuth backchannel provider. The dictionary key "scope" in BuildRefreshParameters is already set in BuildRequestParameters and therefore this throws an exception.
Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
Before being added to the dictionary, _scope undergoes two different checks: Nullability and string.IsNullOrEmpty in the two aforementioned methods. I do not know if this is intentional or not.