-
Notifications
You must be signed in to change notification settings - Fork 615
use async consumer only #1638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use async consumer only #1638
Conversation
|
What's the preference for the resulting name of the consumer. Should it be e.g. IBasicConsumer or IAsyncBasicConsumer? |
|
Please use |
Just to make sure we understood each other: I'm for sure use the api of the IAsyncBasicConsumer, but should the name itself be IAsyncBasicConsumer or do you want to remove the Async part, as there's only one "consumer type", hence IBasicConsumer is sufficient. |
Yes, use that name. Thanks. |
7c16f26 to
2ac2aa4
Compare
|
I agree that |
2ac2aa4 to
d0021aa
Compare
lukebakken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Proposed Changes
Gets rid of the duality of AsyncDefaultConsumer and DefaultConsumer.
Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
There's still a bit more work, but opening this PR now due to #1413 (comment)