* Change IConnection event ConnectionShutdown to AsyncEventHandler
#1551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
lukebakken/async-session-shutdown
branch
from
8e84d74 to
30a102a
Compare
JanEggers
reviewed
May 3, 2024
JanEggers
reviewed
May 3, 2024
lukebakken
force-pushed
the
lukebakken/async-session-shutdown
branch
2 times, most recently
from
a650c2f to
760048c
Compare
* Remove sync methods from `IConsumerDispatcher` * Make several `ISession` methods async * Enable confirms in `PublishMessagesWhileClosingConnAsync` * Ensure `RABBITMQ_LONG_RUNNING_TESTS` and SSL env vars are set for sequential integration tests * Don't immediately await the frame handler close in `TestDisposedWithSocketClosedOutOfBand`
lukebakken
force-pushed
the
lukebakken/async-session-shutdown
branch
from
48cb9e7 to
a3ac58c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IConsumerDispatcherISessionmethods async