Continue simplifying code #1507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1472-20240226-2
branch
from
69a4201 to
050456d
Compare
Part of #1472 * Move some overrides to their base class * Simplify method, add comments * Try to figure out CI error here - https://github.com/rabbitmq/rabbitmq-dotnet-client/actions/runs/8072267202/job/22053764839 * Ensure `_closeReason` is not null * Remove or address TODOs * Revert to calling `AbortAsync` in `Dispose` for connections and channels * Add test showing that `CloseAsync` is not required before `Dispose`
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1472-20240226-2
branch
from
de5b1a6 to
7c75648
Compare
Closed
Saibamen
reviewed
May 16, 2024
This was referenced Sep 15, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1472