Remove synchronous API #1473
Merged
Remove synchronous API #1473
+3,349
−4,250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1472
branch
2 times, most recently
from
12791b0 to
0cab550
Compare
Part of the fix for #1472 * Remove synchronous API methods * Update all usages of `CreateConnection` to use `CreateConnectionAsync` * Ensure that all connections and channels are closed prior to `Dispose` * Use lowest feasible `LangVersion` for projects * Add note about nullable reference types in `RabbitMQ.Client.csproj` * Convert `ManualResetEventSlim` and associated classes to `TaskCompletionSource<bool>` or `SemaphoreSlim` * Only use `ValueTask` for operations that need the performance benefit * Add async passive declaration convenience methods to the async API * Fix missing `CloseAsync` statements prior to disposing `IConnection` and `IChannel` instances * Fix bug where `QueueBindAsync` did not record the binding in an `AutorecoveringChannel` * Added `ProcessUtil` to run command line executables via `async` * Make `TopologyRecoveryExceptionHandler` async * Ensure test classes call `base.DisposeAsync()` appropriately * Add `RABBITMQ_LONG_RUNNING_TESTS=true` to `build.ps1` * Remove `Close` and `Abort` from `IConnection` and `IConnectionExtensions` * Remove `Close` and `Abort` from `IChannel` and `IChannelExtensions` * Remove use of `RecoveryChannelFactory` * Remove `Close` from `AutorecoveringConnection` and `Connection` * Ensure `TestConnectionRecoveryWithoutSetup` tests close and dispose of channels correctly * Remove `ConfirmSelect` * Remove `ExchangeBind` and `ExchangeBindNoWait` * Add `noWait` to `ExchangeBindAsync` and `ExchangeDeclareAsync` * Remove `ExchangeDeclarePassive` * Fix stack overflow in `ExchangeBindAsync` * Remove `ExchangeDelete` and `ExchangeDeleteNoWait` * Remove `BasicGet` * Remove `BasicNack` * Change `BasicNackAsync` to return `ValueTask` * Remove `BasicCancel` and `BasicCancelNoWait` * Remove `BasicPublish` * Remove `BasicQos` * Remove `BasicReject` * Remove `ExchangeUnbind` and `ExchangeUnbindNoWait` * Remove `QueueBind`, `QueueBindNoWait`, QueueDeclare`, `QueueDeclareNoWait`, and `QueueDeclarePassive` * Remove `QueueDelete` and `QueueDeleteNoWait` * Make `noWait` the last param in the arg list. Default is `false` * Remove `BasicAck` * Modify `IBasicConsumer` to make `HandleBasicDeliver` an async method * Move `passive` to the end of the argument list, just before `noWait` * Remove `QueuePurge` * Remove `QueueUnbind` * Remove `TxSelect`, `TxCommit` and `TxRollback` * Remove `WaitForConfirms` and `WaitForConfirmsOrDie` * Remove `BasicConsume` * Delete code for sync API * Make `UpdateSecret` async
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1472
branch
from
7333475 to
b65e07e
Compare
Closed
This was referenced Sep 15, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for #1472