NullReferenceException on AutorecoveringModel.IsClosed

[ig-sinicyn]

RabbitMQ.Client 6.0.0, RabbitMQ.Client.Impl.AutorecoveringModel:

        public bool IsClosed
        {
            get { return _delegate.IsClosed; }
        }

The getter throws null reference for disposed entities. Reason is here:

        private void Dispose(bool disposing)
        {
            if (disposing)
            {
               ...
                _delegate = null;
            }
        }

[lukebakken]

This should be a simple fix, please submit a pull request with a test. Thank you.

[bording]

The question is, what is the correct behavior? If the object is disposed, should that return true or false?

Or should it throw ObjectDisposedException?

[ig-sinicyn]

I'd prefer following behavior:

1. For members that are used to check for connection availability/health - do not throw.
   As far as I can see there are only two properties that should not throw:
   IsOpen (returns false if disposed);
   IsClosed (returns true if disposed).
2. For all other members: throw ObjectDisposedException.

[ig-sinicyn]

@lukebakken I'm quite busy this week so the issue is up for grabs:)

[michaelklishin]

It would be slightly more user-friendly if IsOpen and IsClosed continued acting like predicates and did not throw when the underlying non-recovering connection is disposed of.

[stebet]

Yep. Throwing in Property Getters is considered bad practice.

[lukebakken]

I'm getting this today.