implement SQL Filter #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: #73 Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
closes: #73 Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR implements SQL filter functionality for RabbitMQ AMQP streams, allowing users to filter messages using SQL-like expressions. The implementation adds support for SQL filters in the stream consumer options and includes comprehensive test coverage and documentation.
- Added SQL filter support to StreamConsumerOptions and StreamFilterOptions classes
- Created comprehensive test cases to verify SQL filter functionality
- Updated documentation with a new example demonstrating SQL filter usage
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_streams.py | Added comprehensive test for SQL filter functionality and cleaned up whitespace formatting across existing tests |
| rabbitmq_amqp_python_client/entities.py | Added SQL filter constants, implemented SQL filter logic, and removed unused 'to' property from MessageProperties |
| examples/streams_with_sql_filters/example_streams_with_sql_filters.py | New example demonstrating SQL filter usage with detailed comments and error handling |
| examples/streams_with_filters/example_streams_with_filters.py | Updated queue name to be more descriptive for message properties filter |
| .ci/ubuntu/gha-setup.sh | Updated RabbitMQ Docker image to version 4.2-rc-management |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements SQL filter functionality for RabbitMQ AMQP streams, allowing users to filter messages using SQL-like expressions. The implementation adds support for SQL filters in the stream consumer options and includes comprehensive test coverage and documentation.
Added SQL filter support to StreamConsumerOptions and StreamFilterOptions classes
Created comprehensive test cases to verify SQL filter functionality
Updated documentation with a new example demonstrating SQL filter usage
closes: #73