Ra v3 #494
Draft
Ra v3 #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
v3
branch
2 times, most recently
from
dbb90ff to
08610a0
Compare
kjnilsson
force-pushed
the
v3
branch
2 times, most recently
from
70b7e6e to
3e50dd2
Compare
kjnilsson
force-pushed
the
v3
branch
5 times, most recently
from
f8a3bed to
177855c
Compare
kjnilsson
force-pushed
the
v3
branch
2 times, most recently
from
53636ed to
0f65f08
Compare
kjnilsson
force-pushed
the
v3
branch
2 times, most recently
from
b13920d to
360eb77
Compare
kjnilsson
force-pushed
the
v3
branch
3 times, most recently
from
d3a23c9 to
ab1281f
Compare
kjnilsson
force-pushed
the
v3
branch
2 times, most recently
from
e83b688 to
b4c1959
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR brings test suites in line with the v3 work by updating snapshot and log APIs, renaming backends, and removing obsolete tests.
- Rename
ra_log_readertora_log_segmentsin unit tests - Refactor
ra_snapshot_SUITEto use the newbg_workpattern and updatedpending/complete_snapshotsignatures - Update WAL and memory tests to expect lists of indexes instead of tuple ranges, and remove the legacy property-based suite
Reviewed Changes
Copilot reviewed 52 out of 55 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit_SUITE.erl | Replace ra_log_reader with ra_log_segments |
| test/ra_snapshot_SUITE.erl | Migrate snapshot tests to new begin_snapshot/pending API |
| test/ra_log_wal_SUITE.erl | Adapt await_written to expect lists of indexes |
| test/ra_log_memory.erl | Change install_snapshot/4 to match new live‐indexes signature |
| test/ra_machine_ets_SUITE.erl | Remove Common Test include (ct.hrl) |
| test/ra_log_props_SUITE.erl | Delete entire deprecated property-based suite |
Comments suppressed due to low confidence (2)
test/ra_log_memory.erl:174
- The new
install_snapshot/4clause returns{ok, State, []}but the expected return is{State, List}. Remove theokatom so it matches the spec and callers ({State, []}).
{ra_log_memory_state(), list()}.
test/ra_machine_ets_SUITE.erl:12
- The Common Test macros (e.g.
ct:pal) are used elsewhere in this file. Removing thect.hrlinclude may cause undefined macro errors. Re-add the Common Test include if CT macros are still used.
-export([
611ab22 to
e368de3
Compare
kjnilsson
force-pushed
the
v3
branch
2 times, most recently
from
60d81e4 to
c5ebfca
Compare
1. kill_wal/kill_member picks a random value between 1 and MAX_NODES, not the current number of members. These prevents very frequent kills if there's a small number of nodes 2. restore read_all_keys_loop and stop it when the tests stop
Without that, all values were read from the leader. When a get is performed on a member, the value is read locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for visibility of v3 work.
See: https://github.com/rabbitmq/ra/milestone/7