Skip to content

Replace metrics by seshat counters #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 28, 2021
Merged

Replace metrics by seshat counters #30

merged 4 commits into from
Jul 28, 2021

Conversation

dcorbacho
Copy link
Contributor

@dcorbacho dcorbacho requested a review from kjnilsson May 18, 2021 11:58
@dcorbacho dcorbacho mentioned this pull request May 18, 2021
Closed
11 tasks
kjnilsson
kjnilsson approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@kjnilsson kjnilsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

One suggestion would be to leave the osiris_counters module and api in place and delegate to seshat inside it instead. Just in case we rely on it somewhere.

@michaelklishin
Copy link
Contributor

I thought of the same thing as @kjnilsson 👍

@michaelklishin michaelklishin merged commit 049b281 into master Jul 28, 2021
@michaelklishin michaelklishin deleted the seshat-counters branch July 28, 2021 23:55
@michaelklishin michaelklishin added this to the 1.1.0 milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

@kjnilsson kjnilsson kjnilsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dcorbacho @michaelklishin @kjnilsson