Helper overlay to patch the Operator image #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used in the pipeline to publish to additional registries. [#689] Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
|
Not sure why #689 is related! |
coro
reviewed
Jan 28, 2022
| #@ load("@ytt:overlay", "overlay") | ||
| #@ load("@ytt:data", "data") | ||
|
|
||
| #@overlay/match by=overlay.subset({"kind": "Deployment"}), expects="1+" |
There was a problem hiding this comment.
Is it worth maybe being specific about which Deployment is in the subset? Just in case one used this with a large group of manifests containing other Deployments.
There was a problem hiding this comment.
Good catch! I just hope kustomize doesn't mangle the name of the Deployment ever.
Just to ensure we target the expected Deployment object, in case multiple Deployment objects are added in the future. Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
|
Made the changes to match the Operator deployment more precisely. If we ever change the name of the Operator deployment, the overlay won't match anything, in which case we'll get a red pipeline somewhere. |
coro
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
This will be used in the pipeline to publish to additional registries.
Additional Context
Related [#869]
Local Testing
Make sure you have
yttinstalled, then run:kustomize build config/installation/ | ytt -f- -f config/ytt/overlay-manager-image.yaml \ --data-value operator_image=quay.io/bunny:latestObserve the image of the Operator Deployment is set to
quay.io/bunny:latest.Edit: tag correct issue 🙈