Skip to content

Infinite Scrolling #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Infinite Scrolling #301

wants to merge 9 commits into from

Conversation

SaraVieira
Copy link
Collaborator

@SaraVieira SaraVieira commented May 26, 2021 •
edited
Loading

I can still see some issues with the library, it's super laggy and I feel like it makes the experience waaay jankier.

closes #206

@SaraVieira SaraVieira requested a review from raae May 26, 2021 21:28
SaraVieira
SaraVieira commented May 26, 2021
View reviewed changes
src/features/timeline/TimelineIndexPage.js
@@ -19,17 +20,24 @@ const useStyles = makeStyles((theme) => ({
marginBottom: theme.spacing(3),
},
},
root: { paddingRight: "0" },
page: { maxWidth: "100% !important" },
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hate myself

@raae
Copy link
Owner

raae commented May 27, 2021

I can still see some issues with the library, it's super laggy and I feel like it makes the experience waaay jankier.

Maybe I just need to give up on this infinite scroll thing.... create totally different ui...

@raae
Copy link
Owner

raae commented May 27, 2021

I can still see some issues with the library, it's super laggy and I feel like it makes the experience waaay jankier.

Maybe I just need to give up on this infinite scroll thing.... create totally different ui...

It feels okey on my phone, so let's go ahead.

@raae
Copy link
Owner

raae commented May 29, 2021

Do you have time to complete this before June 1st @SaraVieira?

@SaraVieira
Copy link
Collaborator Author

I don't think so since a vaccine appointment on Monday but will try tomorrow

@SaraVieira
Copy link
Collaborator Author

Let's talk Monday morning if you want

@SaraVieira
Copy link
Collaborator Author

SaraVieira commented Jun 1, 2021 •
edited
Loading

Bugs

  • Click on today does nothing - Change URL to date like in calendar

  • Missing margins

CleanShot 2021-06-01 at 12 08 01@2x

  • [Header slightly smaller than rest

CleanShot 2021-06-01 at 12 07 51@2x

@SaraVieira SaraVieira marked this pull request as ready for review June 1, 2021 18:06
@SaraVieira
Copy link
Collaborator Author

All small issues we talked about today are fixed, let me know what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raae raae Awaiting requested review from raae

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite Timeline scroll
2 participants
@SaraVieira @raae