Fix issue #864 - QucsAttenuator 24.3.0 - Accept "." and "," as decimal separators

[andresmmera]

This PR is intended to fix issue #864.

Prior to this PR, it was not possible to enter decimal values in the design input. To fix this, a custom subclass of QDoubleSpinBox has been created to accept "." and "," as decimal separators.

I will do more extensive tests later.

[andresmmera]

Hi there,

I've done some more extensive testing. As far as I know, everything works as expected.

You can find the test details here.

@csrabak Could you download the Windows build and see if it fixes issue #864 for you?

[wawuwo]

I think more proper approach is to rely on locales mechanism, i.e. to remove the hardcoded C-locale (this line) and let QDoubleValidator use the default locale (which is equal to QLocale()) or to set validator's locale based on the app language setting. Subclassing a widget for this is a bit of an overkill IMO.

[andresmmera]

Hmm, I understand. It actually looks like it's a more elegant solution than mine.

If you already implemented it, I can close this PR and you may open a new one with your solution. Otherwise, I'll try to implement what you say as soon as I can (probably in a few days or the next week).

Thanks a lot @wawuwo

[csrabak]

@andresmmera I'll do and test it and get back to you.

[wawuwo]

@andresmmera no, I haven't implemented anything :)

[csrabak]

@andresmmera

The Windows Build pointed to by you now works as @ra3xdh proposes.

I leave to the team the aspect that in the i18n version, entry can be with commas but the result remains using dot for de radix separator.

[ra3xdh]

I am merging this. Thanks!