Get rid of MouseActions::drawn #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'drawn' is some obscure flag which is scattered all around the codebase, it's mostly set to 'false' and only occasionally to 'true'. It controls blocks of code which are described as "erase old symbol". Honestly, I tried to grasp it's meaning and purpose, and I failed. I believe this flag is just a legacy no one can remember of, and it's OK to remove it. Removing 'MouseActions::drawn' completely doesn't seem to change something, at least at first sight everything looks the same as usual. I cram everything in a single large commit for the sake of easier reverting if it will be needed later.
|
I can schedule the merging of this soon after the v24.3.0 release. I am planning to prepare the release packages in this week. I have assigned v24.4.0 milestone to this PR. |
|
I didn't find any side effects on this PR. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Probably you've seen lines like
or
and so on scattered all around the codebase. This flag is mostly set to 'false' and only occasionally to 'true', and when it's 'true' it enables blocks of code which are described as "erase old symbol". I honestly tried to grasp its meaning and purpose, what "old symbol" is being erased, and I failed. I started thinking that it would be easier to remove it and see what effect it would make.
I tried removing it and surprisingly (or not?) there was no difference at all. Everything looked and behaved as usual, at least at first sight. And now I am asking you to kindly include this change to mainline to test it in real life conditions (testing in prod, yeah 😞).
If there will be no problems discovered in, say, week or month, than we'll be happy having get rid of the dead code. In other case I'll revert it. I crammed everything in a single large commit for the sake of easier reverting if it will be needed later.