-
-
Notifications
You must be signed in to change notification settings - Fork 17
Update Documentation #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ra1028
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for the potential improvement points;
"Parameter atom: An atom that associates the value." (repetitive) → find it confusing, since atoms do associate with value, but not always other way around.
Agreed.
It probably better to have dedicated description per methods while keeping it a very brief description, e.g.
watch: An atom to be watched.read: An atom to read the value
"notifies update to downstream atoms" (repetitive) → can be better without update, or move it to back of the sentence
Agreed to remove update.
Remove pronouns, e.g. "you" → In documentation, might be better avoid using pronouns,
I had the same idea but I vaguely remember that Apple's doc also contains pronouns such as "you" and that's why I used it.
However, I actually don't want to use it in documentation in general so feel free to replace them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! 💯 Thank you @rasberik
The changes will automatically be reflected to our documentation page when next tag release.
Pull Request Type
Description
Update documentation and syntactic & grammar structure of mainly Context and PropertyWrapper parts, and files related to the these changes.
Some examples of repetitive pattern alignments in this PR:
nil" → "The default timeout interval isnilwhich indicates no timeout."atoms or/and views- using or & and have subtle difference, so I reviewed all cases and updated respectfully.Remaining potential improvement points:
May be can address them in separate PR
Motivation and Context
To keep documentation up to date and easier to read.
Impact on Existing Code
None