Skip to content

Minor improvements to the example app. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023
Merged

Minor improvements to the example app. #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions Examples/Packages/iOS/Sources/ExampleMovieDB/Screens/MoviesScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ struct MoviesScreen: View {
@WatchState(SearchQueryAtom())
var searchQuery

@ViewContext
var context

@State
var isShowingSearchScreen = false

Expand Down Expand Up @@ -45,9 +42,12 @@ struct MoviesScreen: View {
}

if let last = pages.last, last.hasNextPage {
ProgressRow().task {
await loader.loadNext()
}
ProgressRow()
// NB: Since ProgressView placed in the List will not redisplay its indicator once it's hidden, here adds a random ID so that it's always regenerated.
.id(UUID())
.task {
await loader.loadNext()
}
}
}
}
Expand All @@ -70,10 +70,7 @@ struct MoviesScreen: View {
await loader.refresh()
}
.refreshable {
// NB: Implicitly capturing `self` causes memory leak with `refreshable`,
// and also capturing `loader` makes refresh doesn't work, so here reads
// `MovieLoader` via context.
await context.read(MovieLoaderAtom()).refresh()
await loader.refresh()
}
.background {
NavigationLink(
Expand Down