Cherry pick bug fix added to 0.7.8 #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is missing (#186) * Refresh now uses a store with the current scope if cache is missing * Fix compilation in Swift 5
There was a problem hiding this comment.
Pull Request Overview
This PR cherry-picks a bug fix for the refresh behavior of atoms by adding new tests and refactoring the context-switching logic within StoreContext. Key changes include:
- New tests for non-cached refresh behavior in both core and custom refreshable atoms.
- Refactoring of StoreContext functions to replace switchContext(scope:) with switchContext(with:) for a more explicit use of AtomCache.
- Adjustments in reset and update functions to work with the new switchContext(with:) API.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Tests/AtomsTests/Core/StoreContextTests.swift | Adds a test for refresh using an override container to return a fixed value. |
| Tests/AtomsTests/Attribute/RefreshableTests.swift | Introduces a custom refresh test for a refreshable atom using dependency overrides. |
| Sources/Atoms/Core/StoreContext.swift | Refactors context switching by replacing switchContext(scope:) with switchContext(with:) and adjusts related calls accordingly. |
| } | ||
|
|
||
| func switchContext(scope: Scope?) -> StoreContext { | ||
| func switchContext(with cache: some AtomCacheProtocol) -> StoreContext { |
There was a problem hiding this comment.
Consider verifying that 'cache.initializedScope' will always provide a non-nil value. If there's any chance it could be nil, it might be beneficial to add an assertion or error handling to prevent propagation of an invalid context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type