Add support for initializing effect in MergedEffect #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new pre-initialization lifecycle hook to MergedEffect so that each merged effect’s initializing method is called before the existing initialized, updated, and released hooks.
- Introduces a private
initializingclosure property. - Updates the initializer to invoke each effect’s
initializingmethod. - Adds a public
initializing(context:)method with documentation.
| /// A lifecycle event that is triggered before the atom is first used and initialized, | ||
| /// or once it is released and re-initialized. | ||
| public func initializing(context: Context) { | ||
| initializing(context) |
There was a problem hiding this comment.
The call to initializing(context) inside public func initializing refers to the method itself, causing infinite recursion. Rename the private closure property (e.g., to _initializing or initializingHandler) or adjust the call to disambiguate the closure (for example self._initializing(context)).
Suggested change
| initializing(context) | |
| _initializing(context) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type