Fix issue where scoped overrides/observers are not reflected #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ra1028
force-pushed
the
fix/scoped-overrides-observers-not-reflected
branch
from
2469a08 to
90b988f
Compare
shingt
approved these changes
Mar 14, 2025
Contributor
shingt
left a comment
shingt
left a comment
There was a problem hiding this comment.
Performed some testing on the app, too / LGTM. Thank you!!
Comment on lines
+5
to
+6
| private let rootScopeKey: ScopeKey | ||
| private let currentScopeKey: ScopeKey? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Expected overrides and observers are not reflected when atoms are updated across the scope boundary.
For example, let's say you have AtomA, which depends on AtomB and AtomC. AtomB is scoped due to override, AtomC is shared. Now, AtomC gets updated, and it also updated the downstream - AtomA. AtomA accesses AtomB to calculate its new value, but it fails to get the overridden value because it's updated from the scope of AtomC, which is not intuitive. In terms of API ergonomics, the AtomA should definitely be updated with the scope in which the AtomA was initialized.