-
-
Notifications
You must be signed in to change notification settings - Fork 17
refactor: DAG algorithm based state management #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e408e9 to
f340e5f
Compare
f340e5f to
50e78cb
Compare
2 tasks
54fb1e9 to
f75b602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Issue for this PR
Link: close #20
Description
Implement Directed Acyclic Graph based dependency graph for better reliability, predictable result, and reproducibility of the internal state.
Motivation and Context
Currently, the core system of this library is implemented with ARC and reactive programing, but it's not 100% reliable and reproducible, it prevents restoration to a specific state.
Using DAG data structure and allows this library to manage a centralized state in a holistic approach.
That's the same approach with Recoil which that this library is inspired.
Impact on Existing Code
It contains a lot of braking changes on ABI, but the existing codes written with a proper usage of Atoms should work without changes.
Performance
= 139% better