Skip to content

Add a comment about inheritance of actor isolation #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Add a comment about inheritance of actor isolation #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Sources/Atoms/AsyncPhase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,13 @@ public enum AsyncPhase<Success, Failure: Error> {
/// returned value as a success, or thrown error as a failure.
///
/// - Parameter body: A async throwing closure to evaluate.
public init(catching body: @Sendable () async throws(Failure) -> Success) async {
public init(
// Adopt SE-0420 Inheritance of actor isolation instead of adding @Sendable
// to the body closure once the compiler crash that happens with Swift 6.0
// when used in an initializer is solved.
// isolation: isolated (any Actor)? = #isolation,
catching body: @Sendable () async throws(Failure) -> Success
) async {
do {
let value = try await body()
self = .success(value)
Expand Down