Detach atom dependencies while executing custom refresh #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasberik
reviewed
May 14, 2024
| release(for: key) | ||
| } | ||
|
|
||
| func detachDependencies(for key: AtomKey) -> Set<AtomKey> { |
Collaborator
There was a problem hiding this comment.
aaah exactly what I wanted to ask (methods or closure to freeze updates to atom), thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Transitive refresh of dependent atoms in a custom refresh was found to cause multiple updates to be notified downstream due to updates of the parent atoms plus the update of self.
As a countermeasure, dependencies are temporarily detached during refresh to prevent update notifications and restored after refresh.