Deprecate context.state(_:) and rename it to context.binding(_:) #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ra1028
force-pushed
the
feat/rename-state-to-binding
branch
from
f9ce00e to
6582bd3
Compare
ra1028
force-pushed
the
feat/rename-state-to-binding
branch
from
6582bd3 to
557965a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
The naming
context.state(_:)doesn't well imply that it returns aBinding, and its existence often goes unnoticed, so it's renamedcontext.binding(_:)that implies directly that it returns aBindingto the atom state.Also, now that only
AtomViewContexthascontext.binding(:_)because it was not needed to allow it to be used on selector atoms.Impact on Existing Code
AtomWatchableContext.state(_:)is deprecated.AtomViewContext.binding(_:)is added.