Deprecate ResetContext & RefreshContext #121
Merged
+23
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Multiple Attributes are available now and each of them has its own context type, so this PR unifies the context type into a single definition
CurrentContextand deprecates existing ones.UpdateContextwas also a target of deprecation. However, I plan to deprecateAtom.updated(newValue:oldValue:context:)API and introduce a brand new way of handling side effects,UpdateContextitself will be deprecated along with it, not only for renaming. Since, protocol methods cannot be marked as deprecated, adding a deprecation message toUpdateContextwould be helpful to make it noticeable.