Animation Modifier #117
Merged
Animation Modifier #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ra1028
force-pushed
the
feat/animation-modifier
branch
2 times, most recently
from
ac9901e to
885c9ea
Compare
ra1028
force-pushed
the
feat/animation-modifier
branch
from
885c9ea to
88411e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
There is an existing problem that when a selector atom that has ObservableObjectAtom as a dependency is being watched from a view, a view animation is not applied when the ObservableObject's properties are updated.
This is because when
objectWillChangeemits the event, it delays updating the view until the next execution of the run loop so that atoms can handle the changed values.For the ObservableObjectAtom being watched directly from the view, we had included a workaround so that the animation was valid, but it was not possible for the cases via another selector atom.
To make a little more stable countermeasure for this problem, this PR removes the internal workaround for enabling animation of ObservableObjectAtom in any case, in other words, it makes it completely not animateable by default, and instead implements
.animation(_:)modifier that allows arbitrary animation to be given to updates.Impact on Existing Code
ObservableObjectAtomno longer animates the view when updated.