Skip to content

Conversation

@ra1028
Copy link
Owner

@ra1028 ra1028 commented Apr 18, 2024

Pull Request Type

  • Bug fix
  • New feature
  • Refactoring
  • Documentation update
  • Chore

Description

  • Do not provide a dummy instance of StoreContext in environment values, and provide nil by default.
  • Retain AtomStore in StoreContext.

Impact on Existing Code

It's possible that some project with doing something tricky around swapping AtomStore instance in runtime because the store is no longer be released immediately, but it's not something we should support.

@ra1028 ra1028 merged commit aae2212 into main Apr 18, 2024
@ra1028 ra1028 deleted the refactor/internal branch April 18, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants