Scoped Override #112
Merged
Scoped Override #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This PR adds a rather non scoped override way and changes the current behavior to a more explicit interface.
With the recent changes, nested AtomScopes is no longer inherits overrides from both AtomRoot, which made dependency injection for the entire app difficult.
This PR changes AtomRoot
overrideto be inherited by all scopes.Impact on Existing Code
AtomScope.override(_:)is deprecated and renamed toAtomScope.scopedOverride(_:).AtomRootis now inherited by any scopes.