Rename select modifier to changes(of:) #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ra1028
force-pushed
the
refactor/rename-select-modifier
branch
from
c934faa to
aa4e561
Compare
ra1028
force-pushed
the
refactor/rename-select-modifier
branch
from
aa4e561 to
d2e635e
Compare
rasberik
reviewed
Apr 9, 2024
| @@ -0,0 +1,8 @@ | |||
| public extension Atom { | |||
| @available(*, deprecated, renamed: "changes(of:)") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
The name
selectgives the wrong impression of simply deriving a property of an atom value, and I frequently saw cases where the important nature that comparing the pre and post change values of a property and suppressing updates when they are equivalent was missed, so this change renames it tochanges(of :)andselectwill be deprecated.Impact on Existing Code
selectwill be deprecated, and renamed tochanges(of:).