Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting in info.plist does not support dark mode #85

Merged
merged 3 commits into from
Dec 9, 2019

Conversation

saucym
Copy link
Contributor

@saucym saucym commented Oct 29, 2019

Checklist

Description

Related Issue

Motivation and Context

Impact on Existing Code

Screenshots (if appropriate)

@saucym saucym changed the title Setting in info.plist does not support dark mode Setting in info.plist does not support dark mode And Make UICollectionView and UITableView have the same reload method Oct 29, 2019
@ra1028
Copy link
Owner

ra1028 commented Nov 8, 2019

Hi @saucym ,

Thanks for the PR.
But, I don't prefer these changes, because the automatic animation is not suitable for the default behavior.

@saucym saucym changed the title Setting in info.plist does not support dark mode And Make UICollectionView and UITableView have the same reload method Setting in info.plist does not support dark mode Nov 8, 2019
@saucym
Copy link
Contributor Author

saucym commented Nov 11, 2019

Hi @saucym ,

Thanks for the PR.
But, I don't prefer these changes, because the automatic animation is not suitable for the default behavior.

Ok, it's also good now.
The current examples is abnormal in dark mode. Disabled in the info.plist file.

@ra1028
Copy link
Owner

ra1028 commented Dec 9, 2019

@saucym
Sorry for my late reply.
Thanks!

@ra1028 ra1028 merged commit 8b06f48 into ra1028:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants