Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from httr to httr2 #276

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Switch from httr to httr2 #276

merged 2 commits into from
Sep 29, 2023

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Sep 27, 2023

  • Changed all references to httr in code to httr2

TO DO:

  • clarify in function documentation how to continue using proxy in the future. Current documentation gives the following advice:
#'   To use a proxy to connect, a [httr::use_proxy()] can be
#'   passed to [httr::GET()]. For example
#'   `get_eurostat_json(id, filters,
#'   config = httr::use_proxy(url, port, username, password))`.

@pitkant pitkant linked an issue Sep 28, 2023 that may be closed by this pull request
@pitkant pitkant marked this pull request as ready for review September 29, 2023 07:22
@pitkant
Copy link
Member Author

pitkant commented Sep 29, 2023

Proxy functionalities are now implemented, needs only testing

@pitkant pitkant merged commit e2598fd into v4-dev Sep 29, 2023
@pitkant pitkant mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from httr to httr2
1 participant