Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated datasets, cleaner imports #239

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Updated datasets, cleaner imports #239

merged 3 commits into from
Jul 20, 2022

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Jul 1, 2022

  • Fixes issue old-style CRS in spatial data. #237 by updating the old dataset with a more current one.
  • Includes more comprehensive documentation about variables in included dataset and datasets downloaded from the Eurostat/GISCO service.
  • dplyr and tidyr namespaces are no longer completely imported into the eurostat package, importFrom is used now instead

@pitkant pitkant requested a review from antagomir July 1, 2022 13:31
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #239 (a866e98) into master (8d5adc9) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a866e98 differs from pull request most recent head ea2eed2. Consider uploading reports for the commit ea2eed2 to get more accurate results

@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   68.12%   68.12%           
=======================================
  Files          22       22           
  Lines         756      756           
=======================================
  Hits          515      515           
  Misses        241      241           
Impacted Files Coverage Δ
R/get_eurostat.R 72.34% <ø> (ø)
R/tidy_eurostat.R 68.85% <ø> (ø)
R/get_eurostat_geospatial.R 92.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5adc9...ea2eed2. Read the comment docs.

@antagomir antagomir merged commit ad9f856 into master Jul 20, 2022
@antagomir antagomir deleted the pitkant branch July 20, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants