Fix typos and cache is crs-aware & man updated #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry @dieghernan - I only noticed this now! You could have pinged me online for this, my ignorance.. :-) Thanks so much! |
|
No worries!! In fact I should thank you as this was the inception of {giscoR}, my first CRAN package |
|
Ok, great :D I have added you as a contributor in the DESCRIPTION file now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #189 and #190
string\stringinstead ofstring\integer(now it isyear == "2016"). Althoughstring\integerworked it seems just right to perform the comparison between the same data types: dieghernan@f93714bcrs-aware. I didn't spotted this one, meaning thatget_eurostat_geospatial(year =2013, crs=4326)andget_eurostat_geospatial(year = 2013, crs=3857)produced the same result (since4326was cached in first place and3857was updated from cache). Potential workaround is to setupdate_cache = FALSE).