Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think both the article and the regional functions can be releasesed #173

Merged
merged 2 commits into from
Feb 9, 2020

Conversation

antaldaniel
Copy link
Contributor

I not only tested them programatically, but on 16 data tables (a large part of all regional) including some very structured ones.

The errrors that came up in the last days were errors with Eurostat's metadata library that I will report to them.

So I think that everything was tested very extensively.

I will add some mapping examples later, but they make more sense with imputation functions, where we can show how this strategy can remove many-many grey missing areas from the map.

I tested apart from devtools the functions in 16 statistical products, altogether even more indicators, as digital ICT is bundled in large, structured tables.

I think that the functions are programatically good, and I have tapped in testing with real life data several issues with the Eurostat published metadata tables.
@antaldaniel antaldaniel merged commit 8f0d910 into rOpenGov:devel Feb 9, 2020
@antagomir
Copy link
Member

Excellent. I will run through tests at this end.

Would it be possible to have the source code for programmatic tests, this could be helpful also with other future updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants