Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two more functions, plus lot of tidying up #169

Merged
merged 8 commits into from
Feb 7, 2020

Conversation

antaldaniel
Copy link
Contributor

So, eventually I added two more functions, one brings the data (when possible without imputation) to NUTS2013 and the other to NUTS2016.

Should the vignette cause a problem, it is not committed now, but it looks like this
https://rpubs.com/antaldaniel/eurostat_regional_data

I think that the last part (recommendations to Eurostat) could go to a blogpost on rOpenGov instead (how?) I also have a long debt to write a longer blogpost about my other, eurostat based CRAN package iotables, which deals with national accounts data. Accidentally, after 4 months, I received an almost meaningful answer from Eurostat to my inquiries, and I think that maybe some dialogue could be started with this release / blogpost.

The vignette now gives a bit of orientation to deal with imputation. I have some imputation functions, too, but probably they are for a later release with hopefully some user feedback on this.

Let me know what to do with the vignette

…the code and changed intendation and punctuation for readability.

I did not change the actual code, except for removing paste() when there was nothing to past, i.e. it had only one expression within a message.
…tidyselect function all_of () and added tidyselect as an explicit dependency.

This is not a new dependency in fact, because the reorganization of tidyverse (with dplyr and tidyr) earlier just moves several low-level tidyverse helper functions to rlang or tidyselect from dplyr and tidyr.
…on names, plus a repeating element taken to utils
…e-standard evaluation / binding issues in devtools by reading in a data element into the local, scoped environment of the new functions.
…UTS2 level data in the same table. This can lead to confusion, and this little helper function helps with joining and filtering.
@antaldaniel antaldaniel merged commit 1c1c606 into rOpenGov:devel Feb 7, 2020
@antagomir
Copy link
Member

Ok, everything seems to work for now. I pushed everything to master, and also the included HTML pages should now appear on our package website. More can be added, the only reason I earlier removed regional_data was that it failed to convert at this end.

Re: article at the package website vs. ropengov (or other) blog post: I think this can be based on a personal judgement on what works best; generic tutorials and advice might be best shared through the package website. More complex examples, case studies, demonstrations, and outreach could also go to blog posts. We are very happy to publish new blog posts at the rOpenGov homepage. This has been a bit lower activity lately due to maintenance issue but new activity could also help us to speed up efforts to speed up the rOpenGov website maintenance.

@antagomir
Copy link
Member

If imputation is not urgent now, perhaps indeed better to do that with a good time for a subsequent release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants