Fixes #64
Fixes #64
Conversation
- Introduced `evaluation`, `evaluation_config`, `target_task_metrics`, and `test_case` tables with appropriate columns and constraints. - Added `evaluation_status` enum for tracking evaluation states. - Created indexes for efficient querying on key columns. - Updated `execution_result` table to include an `input` column and altered `response_schema` type for compatibility.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 30
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
backend/migrations/versions/cb5cec1b033d_add_grader_and_grade.py
Outdated
Show resolved
Hide resolved
backend/migrations/versions/e85591d36b7d_evaluation_and_testing.py
Outdated
Show resolved
Hide resolved
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| finish_reason_enum = postgresql.ENUM( | ||
| "STOP", | ||
| "LENGTH", | ||
| "TOOL_CALLS", | ||
| "CONTENT_FILTER", | ||
| "FUNCTION_CALL", | ||
| "ERROR", | ||
| name="finish_reason", | ||
| create_type=False, |
There was a problem hiding this comment.
This migration creates the Postgres enum as finish_reason, but the ExecutionResult.finish_reason column is still declared with SQLEnum(FinishReason) in backend/app/models/executions.py, which defaults to the type name finishreason. On a clean database the migration will define only finish_reason, yet inserts through SQLAlchemy will cast values to ::finishreason, causing ERROR: type "finishreason" does not exist when saving execution results. Either keep the original enum name or update the model to use name="finish_reason" so both sides agree.
Useful? React with 👍 / 👎.
- Updated `finish_reason` column in `ExecutionResult` model to specify enum name. - Modified migration scripts to drop enum and adjust check constraint names for clarity and consistency.
backend/migrations/versions/2ab7f18e5ff7_restructure_traces_to_match_openai_api.py
Show resolved
Hide resolved
backend/migrations/versions/2ab7f18e5ff7_restructure_traces_to_match_openai_api.py
Show resolved
Hide resolved
- Replaced `@validator` with `@field_validator` in `OptimizationRunRequest` for improved validation. - Updated `ModelResponse` and `ProviderResponse` classes to use `model_config` with `ConfigDict` for configuration management.
- Updated enum values in multiple migration scripts to use lowercase for consistency with OpenAI API standards. - Adjusted `finish_reason`, `item_type`, `score_type`, `evaluation_status`, and `optimization_status` enums accordingly.
| import axios from "axios"; | ||
|
|
||
| const API_BASE_URL = import.meta.env.VITE_API_BASE_URL || "https://api.r4u.dev"; | ||
| const API_BASE_URL = import.meta.env.VITE_API_BASE_URL || "http://localhost:8000"; |
There was a problem hiding this comment.
Bug: Production API points to local development.
The default API_BASE_URL was changed from https://api.r4u.dev to http://localhost:8000, which appears to be a development configuration that was accidentally committed instead of production settings.
Note
Standardizes DB enums and migrations, updates Pydantic schemas to v2, refreshes trace UI color tokens, and defaults the frontend API client to localhost.
finish_reason,item_type,optimization_status,evaluation_status,score_type) with create/drop inupgrade/downgrade(e.g.,backend/migrations/versions/*).execution_result.inputand changetask.response_schemato JSONB with proper downgrade.SQLEnum(FinishReason, name="finish_reason")inbackend/app/models/executions.py.validatorwithfield_validator, and useConfigDict(from_attributes=True)inbackend/app/schemas/optimizations.pyandbackend/app/schemas/providers.py.border-warning/success/primary/accent/destructive/secondary, etc.) infrontend/src/components/trace/InputItemRenderer.tsxand.../OutputItemRenderer.tsx.API_BASE_URLtohttp://localhost:8000infrontend/src/lib/api/client.ts.Written by Cursor Bugbot for commit 751f459. This will update automatically on new commits. Configure here.