Skip to content

Client OnConnect event added #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Conversation

enverbisevac
Copy link
Contributor

OnConnect is callback when request is successful. IMO thisshould part of the client api. if we follow SSE spec then events should be named OnClose and OnOpen.

@purehyperbole
Copy link
Member

Hey @enverbisevac , sorry for the extreme delay in getting back to you.

Unfortunately the usage of default here in the select statement causes the loop to spin while there are no values on either of the other channels. This spinning consumes an entire cpu, so I can't merge this as is.

Are you able to come up with a different solution for your feature please?

@purehyperbole
Copy link
Member

Thanks for the contribution @enverbisevac !

@purehyperbole purehyperbole merged commit 25f230d into r3labs:master Nov 15, 2022
This was referenced Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants